Github user ebortnik commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/13#discussion_r130564921
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/TTable.java ---
@@ -396,20 +443,48 @@ public ResultScanner getScanner(Transaction tx, Scan
scan) throws IOException {
return commitCache;
}
- private boolean isCellInSnapshot(Cell kv, HBaseTransaction
transaction, Map<Long, Long> commitCache)
- throws IOException {
+ private void buildFamilyDeletionCache(List<Cell> rawCells, Map<String,
List<Cell>> familyDeletionCache) {
- long startTimestamp = transaction.getStartTimestamp();
+ for (Cell cell : rawCells) {
+ if (CellUtil.matchingQualifier(cell,
CellUtils.FAMILY_DELETE_QUALIFIER) &&
+ CellUtil.matchingValue(cell,
HConstants.EMPTY_BYTE_ARRAY)) {
+
+ String row = Bytes.toString(cell.getRow());
+ List<Cell> cells = familyDeletionCache.get(row);
+ if (cells == null) {
+ cells = new ArrayList<>();
+ familyDeletionCache.put(row, cells);
+ }
- if (kv.getTimestamp() == startTimestamp) {
- return true;
+ cells.add(cell);
+ }
}
- Optional<Long> commitTimestamp =
-
tryToLocateCellCommitTimestamp(transaction.getTransactionManager(),
transaction.getEpoch(), kv,
- commitCache);
+ }
- return commitTimestamp.isPresent() && commitTimestamp.get() <
startTimestamp;
+ private Optional<Long> getCommitTimestamp(Cell kv, HBaseTransaction
transaction, Map<Long, Long> commitCache)
+ throws IOException {
+
+ long startTimestamp = transaction.getStartTimestamp();
+
+ if (kv.getTimestamp() == startTimestamp) {
+ return Optional.of(startTimestamp);
+ }
+
+ Optional<Long> commitTimestamp =
--- End diff --
You can just return the result, no need in the variable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
