Github user ebortnik commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/13#discussion_r130549454
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/TTable.java ---
@@ -346,11 +373,31 @@ public ResultScanner getScanner(Transaction tx, Scan
scan) throws IOException {
}
Map<Long, Long> commitCache = buildCommitCache(rawCells);
+ buildFamilyDeletionCache(rawCells, familyDeletionCache);
- for (Collection<Cell> columnCells :
groupCellsByColumnFilteringShadowCells(rawCells)) {
+ for (Collection<Cell> columnCells :
groupCellsByColumnFilteringShadowCellsAndFamilyDeletion(rawCells)) {
boolean snapshotValueFound = false;
Cell oldestCell = null;
for (Cell cell : columnCells) {
+ List<Cell> familyDeletionCells =
familyDeletionCache.get(Bytes.toString((cell.getRow())));
--- End diff --
Many loops and break, consider breaking to functions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
