> On Oct. 31, 2012, 7:28 a.m., Mohammad Islam wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 71 > > <https://reviews.apache.org/r/7801/diff/1/?file=183356#file183356line71> > > > > do we need to add the default server by default? may be no body is > > using the default server.
> On Oct. 31, 2012, 7:28 a.m., Mohammad Islam wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 89 > > <https://reviews.apache.org/r/7801/diff/1/?file=183356#file183356line89> > > > > partitionKV could be a list of part_key =part _val. > > For example, ds=20120912, region=us is ***one** partition. changing from String partitionKV to partitionMap - consistent across HCatURI class as well as HCat core code of specifying partitions > On Oct. 31, 2012, 7:28 a.m., Mohammad Islam wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 94 > > <https://reviews.apache.org/r/7801/diff/1/?file=183356#file183356line94> > > > > throwing more specific exception other than generalized exception > > XException could be better. implementing separate exception class for metadata related errors > On Oct. 31, 2012, 7:28 a.m., Mohammad Islam wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 96 > > <https://reviews.apache.org/r/7801/diff/1/?file=183356#file183356line96> > > > > this is not really a partition id. right? > > More importantly, is it a good idea in this case. In most of the cases, > > one table could have thousands of partitions. Every key will have extra > > "table name:. Might need to revisit this. adding 1 level of indirection - tableName -> partition map(instead of misleading partitionKV string) > On Oct. 31, 2012, 7:28 a.m., Mohammad Islam wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 164 > > <https://reviews.apache.org/r/7801/diff/1/?file=183356#file183356line164> > > > > if this is the last item in missing Map, we should remove from > > hcatInstanceMap. implementing cascade deletion of parent key on last entry being removed > On Oct. 31, 2012, 7:28 a.m., Mohammad Islam wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionInfo.java, > > line 28 > > <https://reviews.apache.org/r/7801/diff/1/?file=183357#file183357line28> > > > > class name 'PartitionInfo' looks misnomer. > > There is nothing related to partition. It store a list of actions and > > TS. changing to something else. thnx - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7801/#review12942 ----------------------------------------------------------- On Oct. 31, 2012, 2:02 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7801/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2012, 2:02 a.m.) > > > Review request for oozie. > > > Description > ------- > > WIP. Implementing the data structures and interfacing methods which are used > by all other services > > > This addresses bug OOZIE-1039. > https://issues.apache.org/jira/browse/OOZIE-1039 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml > 1403871 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionInfo.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManager.java > PRE-CREATION > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1403871 > > Diff: https://reviews.apache.org/r/7801/diff/ > > > Testing > ------- > > unit tests in progress > > > Thanks, > > Mona Chitnis > >
