----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7801/#review13207 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28416> Looks like , the same piece of code (to find the actionList) is used in three places. It will be better to write a common method and call it from all 3 places. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28412> what happen to the "else" of this "if". "else" section is missing. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28413> is it possible to make it like formal java doc format? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28414> returning a boolean might be helpful in some cases. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28417> same return boolean. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionsGroup.java <https://reviews.apache.org/r/7801/#comment28418> Part..Wrap.. contains server/db/table info. Also PartitionGroup is used in HcatInstanceMap where server/db/table are already in the key. Same thing two place. Also look at line 58 of Partition..MangerService class. - Mohammad Islam On Nov. 6, 2012, 9:14 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7801/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 9:14 a.m.) > > > Review request for oozie. > > > Description > ------- > > Implementing the data structures for handling Partition-based dependencies > and interfacing methods which are used by all other services > > > This addresses bug OOZIE-1039. > https://issues.apache.org/jira/browse/OOZIE-1039 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetadataServiceException.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionsGroup.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/WaitingActions.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XDataTestCase.java > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1404444 > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1404444 > > Diff: https://reviews.apache.org/r/7801/diff/ > > > Testing > ------- > > unit tests included > > > Thanks, > > Mona Chitnis > >
