----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7801/#review13090 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetadataServiceException.java <https://reviews.apache.org/r/7801/#comment28206> replace HadoopAccessorService http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetadataServiceException.java <https://reviews.apache.org/r/7801/#comment28207> same http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28208> adding default in the prop name could be more meaning ful. like hcat.default.server.name http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28209> cut-paste error. should be db. also put "default" in prop name http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28210> add what will be the key and value of table map http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28211> can missingMap be null. safer just check missingMap != null && http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28212> in place of calling two methods. Call one method like actionList.addActions(actionId), that will add and update the last mod time http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28213> This is not a good idea. Wandering if passing templates <P, A> is good. Why can't do the actual type. Because very unlikely to support any other type. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28214> better to replace with something like this: tablePartitionsMap.put(partition, getActionList(partition, actionId)) http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28215> Similar one returns "boolean". this one is void. any reason? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28216> same http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28217> why keeping the string as value for partition, in place of the object itself? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28218> Add the missing entry in the log http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28219> same http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28220> same http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/7801/#comment28222> who will call it? I believe there should be a new class like "Partition" that will hold the hash map of key=value. We can talk on this. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/7801/#comment28221> ultimately this should not be in ooze-default.xml. because it is not a mandatory service - Mohammad Islam On Nov. 4, 2012, 5:18 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7801/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2012, 5:18 p.m.) > > > Review request for oozie. > > > Description > ------- > > Implementing the data structures for handling Partition-based dependencies > and interfacing methods which are used by all other services > > > This addresses bug OOZIE-1039. > https://issues.apache.org/jira/browse/OOZIE-1039 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetadataServiceException.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/WaitingActions.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/oozie-default.xml > 1404444 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > PRE-CREATION > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1404444 > > Diff: https://reviews.apache.org/r/7801/diff/ > > > Testing > ------- > > unit tests included > > > Thanks, > > Mona Chitnis > >
