----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8835/#review15085 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java <https://reviews.apache.org/r/8835/#comment32671> This doesn't work as we discussed. We can fix this in a separate jira. WE need a new JPAexecutor. branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/8835/#comment32678> Can you rename it to dependencyMap or better create a inner class with getters. Its confusing when reading the code. branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/8835/#comment32677> Can you check if this will cause NPE elsewhere? branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java <https://reviews.apache.org/r/8835/#comment32680> To be removed and addressed in a different jira with a new JPAExecutor - Rohini Palaniswamy On Jan. 4, 2013, 8:51 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8835/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2013, 8:51 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1156 > > > This addresses bug OOZIE-1156. > https://issues.apache.org/jira/browse/OOZIE-1156 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1428686 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1428686 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > 1428686 > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-hcat.xml > PRE-CREATION > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-neg-hcat.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/8835/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
