> On Jan. 8, 2013, 6:58 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java, > > line 123 > > <https://reviews.apache.org/r/8835/diff/3/?file=245463#file245463line123> > > > > null/empty check for availDepList before the JPA executor is invoked?
discussed offline..not required as OOZIE-1161 takes care of it > On Jan. 8, 2013, 6:58 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 594 > > <https://reviews.apache.org/r/8835/diff/3/?file=245464#file245464line594> > > > > rename to multiple i.e. createPartitionWrapper*s* for clarity will do before committing > On Jan. 8, 2013, 6:58 p.m., Mona Chitnis wrote: > > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-hcat.xml, > > line 63 > > <https://reviews.apache.org/r/8835/diff/3/?file=245467#file245467line63> > > > > typo? I dont see LOCAL_A will remove the entire block from here and from coord-job-for-neg.xml before commit - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8835/#review15149 ----------------------------------------------------------- On Jan. 7, 2013, 9:30 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8835/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 9:30 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1156 > > > This addresses bug OOZIE-1156. > https://issues.apache.org/jira/browse/OOZIE-1156 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1430019 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1430019 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1430019 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1430019 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1430019 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1430019 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > 1430019 > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-hcat.xml > PRE-CREATION > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-neg-hcat.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/8835/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
