> On Jan. 5, 2013, 1:08 a.m., Rohini Palaniswamy wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java, > > line 429 > > <https://reviews.apache.org/r/8835/diff/1/?file=244992#file244992line429> > > > > Can you rename it to dependencyMap or better create a inner class with > > getters. Its confusing when reading the code.
Renamed to dependency Map.. The function has around 80 lines of code and is not well written. I thought of restructuring it but it will take some effort to rewrite it and can cause regression. So I dont prefer to do this as part of this JIRA. > On Jan. 5, 2013, 1:08 a.m., Rohini Palaniswamy wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java, > > lines 472-479 > > <https://reviews.apache.org/r/8835/diff/1/?file=244992#file244992line472> > > > > Can you check if this will cause NPE elsewhere? dependencyMap is local variable and checked other places for NPE - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8835/#review15085 ----------------------------------------------------------- On Jan. 4, 2013, 8:51 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8835/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2013, 8:51 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1156 > > > This addresses bug OOZIE-1156. > https://issues.apache.org/jira/browse/OOZIE-1156 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1428686 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1428686 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1428686 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > 1428686 > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-hcat.xml > PRE-CREATION > branches/hcat-intre/core/src/test/resources/coord-job-for-matd-neg-hcat.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/8835/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
