[ 
https://issues.apache.org/jira/browse/OOZIE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547571#comment-13547571
 ] 

Robert Kanter commented on OOZIE-1054:
--------------------------------------

Looks better:

A few things:
1) Make sure to generate the patch without the preceding {{a/}} and {{b/}} 
(--no-prefix for git)
2) Some of the indenting is off in {{OozieFSCLI#run}}; make sure to use spaces, 
not tabs
3) The usage information printed out by oozie-setup.sh should mention the 
-sharelib argument
4) Update the documentation; make sure to mention that (by default) it should 
be run as the user who is going to be running the Oozie server
5) The sharelib location is actually configurable in oozie-site.xml; 
{{OozieFSCLI}} should read oozie-site (see {{OozieDBCLI}} for how its done 
there via {{Services}}) and use the value of the 
{{oozie.service.WorkflowAppService.system.libpath}} property for the 
destination path
6) Right now, when you run the -sharelib argument, it will prepare the war 
file, even if the user already did that.  I think it would be better if you 
changed it to be more like what Alejandro suggested on Nov 07 ($ oozie-setup.sh 
[prepare-war|create-db|upgrade-db|create-sharelib|upgrade-sharelib]) and that 
giving no arguments would print out the usage info.  
7) It would be nice if the script/java could accept either a folder or the 
sharelib tar archive (and automatically expand it)
                
> Create script to properly upload sharelib to HDFS
> -------------------------------------------------
>
>                 Key: OOZIE-1054
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1054
>             Project: Oozie
>          Issue Type: New Feature
>          Components: scripts
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Bowen Zhang
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: oozie-1054.patch
>
>
> A common confusion-point for users is how to properly install the sharelib in 
> HDFS.  It would be really useful if we could create a script to properly 
> upload the sharelib to HDFS so we can get rid of the confusion around this.  
> Alternatively, instead of a new script, we could have the oozie-setup.sh 
> script take an argument that does this.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to