> On Jan. 24, 2013, 5:33 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java, line 263 > > <https://reviews.apache.org/r/9079/diff/1/?file=251437#file251437line263> > > > > Can we also add a out = null after close. > > > > http://wiki.apache.org/tomcat/FAQ/KnownIssues#ImageIOIssues
Actually you need to do the out.close() and out = null in finally also. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/#review15647 ----------------------------------------------------------- On Jan. 24, 2013, 1:59 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9079/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 1:59 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1186 > > > This addresses bug OOZIE-1186. > https://issues.apache.org/jira/browse/OOZIE-1186 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1437616 > trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1437616 > trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 1437616 > > Diff: https://reviews.apache.org/r/9079/diff/ > > > Testing > ------- > > unit test done + end-to-end using Yourkit memory profiler > > > Thanks, > > Mona Chitnis > >
