----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/#review15679 -----------------------------------------------------------
Ship it! +1..Good to know about dispose(). It seems we misread the javadoc. It was probably saying that if we override the paint(Graphics g) of Component, g.dispose() shouldn't be called within the method as the graphics object was not created by us trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java <https://reviews.apache.org/r/9079/#comment33823> remove println statement - Virag Kothari On Jan. 25, 2013, 3:46 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9079/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 3:46 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1186 > > > This addresses bug OOZIE-1186. > https://issues.apache.org/jira/browse/OOZIE-1186 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1437616 > trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 1437616 > > Diff: https://reviews.apache.org/r/9079/diff/ > > > Testing > ------- > > unit test done + end-to-end using Yourkit memory profiler > > > Thanks, > > Mona Chitnis > >
