----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/#review15651 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java <https://reviews.apache.org/r/9079/#comment33767> Test case is not required. We can remove the extra boolean parameter if it was just for testcase. trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java <https://reviews.apache.org/r/9079/#comment33755> not required trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java <https://reviews.apache.org/r/9079/#comment33763> The test case fails/passes inconsistently. I also tried with thread.sleep() to allow some time for the memory to be freed but doesn't work. System.gc() is just an indicator for garbage collection and wont help Its ok to not have a testcase as its difficult to write a unit test for a patch which is just flushing system resources and not solving a memory leak issue. - Virag Kothari On Jan. 24, 2013, 1:59 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9079/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 1:59 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1186 > > > This addresses bug OOZIE-1186. > https://issues.apache.org/jira/browse/OOZIE-1186 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1437616 > trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java 1437616 > trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 1437616 > > Diff: https://reviews.apache.org/r/9079/diff/ > > > Testing > ------- > > unit test done + end-to-end using Yourkit memory profiler > > > Thanks, > > Mona Chitnis > >
