-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9104/#review15670
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java
<https://reviews.apache.org/r/9104/#comment33803>

    It seems that all columns are retrieved which is not different from select 
*.
    Can you check whether some of the columns (mainly blob's) are internal to 
Oozie and not useful for the user?



trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
<https://reviews.apache.org/r/9104/#comment33804>

    It will be good to add a test case for this JPA executor


- Virag Kothari


On Jan. 25, 2013, 12:18 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9104/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 12:18 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1187
> 
> 
> This addresses bug OOZIE-1187.
>     https://issues.apache.org/jira/browse/OOZIE-1187
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603 
>   trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java
>  1437603 
>   
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
>  1437603 
>   trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603 
> 
> Diff: https://reviews.apache.org/r/9104/diff/
> 
> 
> Testing
> -------
> 
> locally tested. ran coordinator jobs with SLA tag inserted
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Reply via email to