> On Feb. 2, 2013, 10:44 p.m., Rohini Palaniswamy wrote: > > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki, lines 750-752 > > <https://reviews.apache.org/r/9104/diff/7/?file=254946#file254946line750> > > > > We can avoid a new example. We can add offset option to the previous > > example and a note that offset is same as sequenceid to be concise.
we should keep both examples separate to minimize confusion. one customer didn't know -offset set to be sequenceid - 1, having both examples help clarify that as well. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9104/#review16040 ----------------------------------------------------------- On Feb. 2, 2013, 7:35 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9104/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2013, 7:35 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1187 > > > This addresses bug OOZIE-1187. > https://issues.apache.org/jira/browse/OOZIE-1187 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440866 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440866 > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java > 1440866 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1440866 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1440866 > trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1440866 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java > 1440866 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java > 1440866 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1440866 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440866 > > Diff: https://reviews.apache.org/r/9104/diff/ > > > Testing > ------- > > locally tested. ran coordinator jobs with SLA tag inserted > > > Thanks, > > Ryota Egashira > >
