> On Jan. 25, 2013, 2:11 a.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java, line 46 > > <https://reviews.apache.org/r/9104/diff/2/?file=251878#file251878line46> > > > > It seems that all columns are retrieved which is not different from > > select *. > > Can you check whether some of the columns (mainly blob's) are internal > > to Oozie and not useful for the user?
good point. current implementation is that, when SLA even status in Created, giving values in all columns, and when status is in STARTED, SUCCEEDED, KILLED, FAILED, giving only subset. thus, in query, fetching all columns. I created OOZIE-1189 which can be used to fetch all columns on particular SLA event, so in this JIRA, should be enough to give only subset (as long as giving sequence ID and SLA ID, which later used to get details). - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9104/#review15670 ----------------------------------------------------------- On Jan. 25, 2013, 12:18 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9104/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 12:18 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1187 > > > This addresses bug OOZIE-1187. > https://issues.apache.org/jira/browse/OOZIE-1187 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1437603 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1437603 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1437603 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1437603 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1437603 > > Diff: https://reviews.apache.org/r/9104/diff/ > > > Testing > ------- > > locally tested. ran coordinator jobs with SLA tag inserted > > > Thanks, > > Ryota Egashira > >
