----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review18233 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java <https://reviews.apache.org/r/9709/#comment38436> Is the parameter tzId required? no usage. trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java <https://reviews.apache.org/r/9709/#comment38437> if (jmsTopicService != null) just for the safety.. trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java <https://reviews.apache.org/r/9709/#comment38438> take out 'not' pls trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java <https://reviews.apache.org/r/9709/#comment38439> take out this. trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java <https://reviews.apache.org/r/9709/#comment38440> is it "-B_" not "_B@"? trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java <https://reviews.apache.org/r/9709/#comment38441> why do we need this type of topic? trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java <https://reviews.apache.org/r/9709/#comment38442> same trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java <https://reviews.apache.org/r/9709/#comment38443> same trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java <https://reviews.apache.org/r/9709/#comment38444> No sure we need it for 'v0'. Also not sure if we need new 'v2'. because this change in REST API. Open question.. trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/9709/#comment38445> pls takeout all RED color trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/9709/#comment38446> Description might need to be changed based on "user.jobid" - Mohammad Islam On March 21, 2013, 7:40 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9709/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 7:40 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1235 > > > This addresses bug OOZIE-1235. > https://issues.apache.org/jira/browse/OOZIE-1235 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1459407 > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407 > trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407 > trunk/core/src/main/resources/oozie-default.xml 1459407 > trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1459407 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java > 1459407 > > Diff: https://reviews.apache.org/r/9709/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
