> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java, > > line 38 > > <https://reviews.apache.org/r/9709/diff/2/?file=272988#file272988line38> > > > > Is the parameter tzId required? no usage.
Not required. Will remove. Result of copying code from other bean. > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java, > > line 35 > > <https://reviews.apache.org/r/9709/diff/2/?file=272993#file272993line35> > > > > if (jmsTopicService != null) > > just for the safety.. kk > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, > > line 87 > > <https://reviews.apache.org/r/9709/diff/2/?file=272996#file272996line87> > > > > take out 'not' pls kk > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, > > line 139 > > <https://reviews.apache.org/r/9709/diff/2/?file=272996#file272996line139> > > > > is it "-B_" not "_B@"? For bundle, its -B_ > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, > > line 160 > > <https://reviews.apache.org/r/9709/diff/2/?file=272996#file272996line160> > > > > why do we need this type of topic? Had an offline discussion with Mohammad. jobId is unique and user.jobId is not beneficial in any way. So will remove > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java, line > > 212 > > <https://reviews.apache.org/r/9709/diff/2/?file=272998#file272998line212> > > > > No sure we need it for 'v0'. Also not sure if we need new 'v2'. because > > this change in REST API. > > Open question.. Based on offline discussion with Mohammad, things might break if newer client is talking to an older server. But the impact is minimal for breaking such a comptability. So we can just keep in v1. For v0, we are only throwing an Exception. So that is fine. > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/resources/oozie-default.xml, line 149 > > <https://reviews.apache.org/r/9709/diff/2/?file=273000#file273000line149> > > > > pls takeout all RED color kk > On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/resources/oozie-default.xml, line 158 > > <https://reviews.apache.org/r/9709/diff/2/?file=273000#file273000line158> > > > > Description might need to be changed based on "user.jobid" - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review18233 ----------------------------------------------------------- On March 21, 2013, 7:40 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9709/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 7:40 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1235 > > > This addresses bug OOZIE-1235. > https://issues.apache.org/jira/browse/OOZIE-1235 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1459407 > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407 > trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407 > trunk/core/src/main/resources/oozie-default.xml 1459407 > trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1459407 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java > 1459407 > > Diff: https://reviews.apache.org/r/9709/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
