> On April 8, 2013, 7:14 p.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java, > > line 26 > > <https://reviews.apache.org/r/9709/diff/3/?file=274003#file274003line26> > > > > Is this class corresponding to a DB table? I think the norm we follow > > is 'bean' corresponds to persistence
Not necessariy persisted to db, but nything that can be serialized and later constructed back will be a bean. So this will be a bean as it is converted to json and then can later be converted back to java object > On April 8, 2013, 7:14 p.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java, > > line 54 > > <https://reviews.apache.org/r/9709/diff/3/?file=274004#file274004line54> > > > > check for NPE, or maybe you are accounting for all exceptions in catch > > block - then never mind JMSServerInfo cannot be null. So NPE unlikely > On April 8, 2013, 7:14 p.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java, > > line 136 > > <https://reviews.apache.org/r/9709/diff/3/?file=274011#file274011line136> > > > > how come for bundle action ids, its underscore and the rest is '@'? That is a mystery to me too :) - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review18790 ----------------------------------------------------------- On March 23, 2013, 1:32 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9709/ > ----------------------------------------------------------- > > (Updated March 23, 2013, 1:32 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1235 > > > This addresses bug OOZIE-1235. > https://issues.apache.org/jira/browse/OOZIE-1235 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1459407 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1459407 > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1459407 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1459407 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1459407 > trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1459407 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1459407 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1459407 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/command/JMSInfoXCommand.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobGetForUserJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForUserJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/DefaultJMSServerInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSServerInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 1459407 > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1459407 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1459407 > trunk/core/src/main/resources/oozie-default.xml 1459407 > trunk/core/src/test/java/org/apache/oozie/command/TestJMSInfoXCommand.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSServerInfo.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1459407 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java > 1459407 > > Diff: https://reviews.apache.org/r/9709/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
