-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18599
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java
<https://reviews.apache.org/r/9602/#comment39001>

    if (eventsConfigured) {generateEvent}



trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/9602/#comment39002>

    if (eventsConfigured) generateEvent();



trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/9602/#comment39003>

    can you add other properties like conf_listeners?



trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
<https://reviews.apache.org/r/9602/#comment39015>

    discussed offline..need to assert for all event attributes



trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java
<https://reviews.apache.org/r/9602/#comment39014>

    discussed offline..make this inner class of EHS and remove this file
    


- Virag Kothari


On April 1, 2013, 10:23 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 10:23 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
> 
> 
> This addresses bug OOZIE-1209.
>     https://issues.apache.org/jira/browse/OOZIE-1209
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882 
>   trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 
> PRE-CREATION 
>   trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java 
> PRE-CREATION 
>   trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java
>  1462882 
>   trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
>  1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 
> 1462882 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 
> 1462882 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 
> 1462882 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 
> 1462882 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 
> 1462882 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 
> 1462882 
>   trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 
> PRE-CREATION 
>   
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java
>  PRE-CREATION 
>   
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java
>  PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 
> PRE-CREATION 
>   trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 
> 1462882 
>   
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java
>  PRE-CREATION 
>   trunk/core/src/main/resources/oozie-default.xml 1462882 
>   
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java
>  1462882 
>   trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 
> PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 
> PRE-CREATION 
>   
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java
>  PRE-CREATION 
>   trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9602/diff/
> 
> 
> Testing
> -------
> 
> unit tests added
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>

Reply via email to