-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10569/
-----------------------------------------------------------

(Updated May 16, 2013, 10:36 p.m.)


Review request for oozie.


Changes
-------

Addressed Mohammad's and Rohini's review comments. Please check so can commit 


Description
-------

1. Revisiting the SLA handling in Oozie
2. Addition of a calculator service to process sla events in a continuous 
fashion
3. Added new oozie-sla schema v0.2, concise and relevant


This addresses bug OOZIE-1244.
    https://issues.apache.org/jira/browse/OOZIE-1244


Diffs (updated)
-----

  trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION 
  trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1483581 
  trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java 
1483581 
  trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1483581 
  trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1483581 
  trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java 
1483581 
  trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java 
1483581 
  
trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java
 1482602 
  
trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java
 1482602 
  
trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java
 1482171 
  
trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java
 1482171 
  
trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java
 1482171 
  
trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java
 1482171 
  trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 
1483581 
  trunk/client/src/main/resources/oozie-coordinator-0.4.xsd 1483581 
  trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION 
  trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd 1483581 
  trunk/client/src/main/resources/oozie-workflow-0.5.xsd PRE-CREATION 
  trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 
1483581 
  trunk/core/pom.xml 1483581 
  trunk/core/src/main/conf/oozie-site.xml 1483581 
  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 
1483581 
  
trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java
 PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 
1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 
1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 
1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 1483581 
  
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java 
1483581 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java
 1483581 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java
 PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java
 PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java
 PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java
 PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java 
PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 
PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 
PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 
PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java
 1483581 
  trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java 
PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java 
PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java 
PRE-CREATION 
  trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/util/XmlUtils.java 1483581 
  trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 
1483581 
  trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 
1483581 
  trunk/core/src/main/resources/META-INF/persistence.xml 1483581 
  trunk/core/src/main/resources/oozie-default.xml 1483581 
  trunk/core/src/test/java/org/apache/oozie/TestSLAEventBean.java 1483581 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java
 1483581 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 1483581 
  trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 
1483581 
  trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1483581 
  
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java
 1483581 
  trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 
1483581 
  
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 
1483581 
  trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 
1483581 
  
trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java
 PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 
PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 
PRE-CREATION 
  
trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java
 PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 
PRE-CREATION 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1483581 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1483581 
  trunk/core/src/test/resources/coord-action-sla.xml PRE-CREATION 
  trunk/core/src/test/resources/wf-action-sla.xml PRE-CREATION 
  trunk/core/src/test/resources/wf-job-sla.xml PRE-CREATION 
  trunk/examples/src/main/apps/sla/coordinator.xml 1483581 
  trunk/examples/src/main/apps/sla/job.properties 1483581 
  trunk/examples/src/main/apps/sla/workflow.xml 1483581 
  trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1483581 

Diff: https://reviews.apache.org/r/10569/diff/


Testing
-------

ongoing


Thanks,

Mona Chitnis

Reply via email to