----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10569/ -----------------------------------------------------------
(Updated May 16, 2013, 1:23 a.m.) Review request for oozie. Changes ------- Incorporated review comments. If you seeing diff between revision6 and revision7, you will see classes from client.event.message package, which were part of rev6 by mistake and removed now in rev7. Also might see diff in JMSTopicService, but this is not induced by my patch. Will take care when committing. Description ------- 1. Revisiting the SLA handling in Oozie 2. Addition of a calculator service to process sla events in a continuous fashion 3. Added new oozie-sla schema v0.2, concise and relevant This addresses bug OOZIE-1244. https://issues.apache.org/jira/browse/OOZIE-1244 Diffs (updated) ----- trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1482602 trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java 1482602 trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1482602 trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1482602 trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java 1482602 trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java 1482602 trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1482602 trunk/client/src/main/resources/oozie-coordinator-0.4.xsd 1482602 trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd 1482602 trunk/client/src/main/resources/oozie-workflow-0.5.xsd PRE-CREATION trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java 1482602 trunk/core/pom.xml 1482602 trunk/core/src/main/conf/oozie-site.xml 1482602 trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1482602 trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1482602 trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1482602 trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java 1482602 trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java 1482602 trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java 1482602 trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1482602 trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java 1482602 trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java 1482602 trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java 1482602 trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java 1482602 trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java 1482602 trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java 1482602 trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java 1482602 trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1482602 trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java 1482602 trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java 1482602 trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 1482602 trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1482602 trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java 1482602 trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java PRE-CREATION trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1482602 trunk/core/src/main/java/org/apache/oozie/util/XmlUtils.java 1482602 trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1482602 trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 1482602 trunk/core/src/main/resources/META-INF/persistence.xml 1482602 trunk/core/src/main/resources/oozie-default.xml 1482602 trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1482602 trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1482602 trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1482602 trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1482602 trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1482602 trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 1482602 trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 1482602 trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 1482602 trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java PRE-CREATION trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1482602 trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1482602 trunk/core/src/test/resources/coord-action-sla.xml PRE-CREATION trunk/core/src/test/resources/wf-action-sla.xml PRE-CREATION trunk/core/src/test/resources/wf-job-sla.xml PRE-CREATION trunk/examples/src/main/apps/sla/coordinator.xml 1482602 trunk/examples/src/main/apps/sla/job.properties 1482602 trunk/examples/src/main/apps/sla/workflow.xml 1482602 trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1482602 Diff: https://reviews.apache.org/r/10569/diff/ Testing ------- ongoing Thanks, Mona Chitnis