----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10569/#review20534 -----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java <https://reviews.apache.org/r/10569/#comment42323> alert events trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java <https://reviews.apache.org/r/10569/#comment42324> Javadoc trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment42326> Remove all non-Javadoc. They have no use. Override will take care of the javadoc trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment42327> setters for the new methods? trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java <https://reviews.apache.org/r/10569/#comment42325> Also add a note to use client.event.SLAEvent class trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment42352> Move these methods after the getters and setters trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment42348> Str to be removed from method name. trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java <https://reviews.apache.org/r/10569/#comment42349> Should be the value passed through setter. Shouldn't the map be updated when you setSlaConfig trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java <https://reviews.apache.org/r/10569/#comment42359> entity manager as argument trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java <https://reviews.apache.org/r/10569/#comment42360> entity manager as argument trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/10569/#comment42361> Why not type case JobEventListener here itself similar to JobEvent. Generics on invokeJobEventListener is redundant trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42377> Remove from here, but put just the job id into another hashset trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42363> Move this inside if block trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42378> In the else block, check in the hashset containing processed jobids. If it is there, just update end time, actual duration and job status. trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/10569/#comment42364> check for if isStartProcessed. If that's the case, just update start time. trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java <https://reviews.apache.org/r/10569/#comment42367> Why ignorecase? trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java <https://reviews.apache.org/r/10569/#comment42370> isConfigured. Same as EHS trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java <https://reviews.apache.org/r/10569/#comment42379> Can move this to SLACalculatorMemory and call updateAllSlaStatus() trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java <https://reviews.apache.org/r/10569/#comment42328> org.apache.oozie.sla package trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java <https://reviews.apache.org/r/10569/#comment42371> Automatically update without explicitly setting trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/10569/#comment42372> capitalize trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java <https://reviews.apache.org/r/10569/#comment42376> Not used in test anywhere trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java <https://reviews.apache.org/r/10569/#comment42374> alert_events. Not used in test anywhere though trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java <https://reviews.apache.org/r/10569/#comment42375> alert_events. Not used in test anywhere though trunk/core/src/test/resources/coord-action-sla.xml <https://reviews.apache.org/r/10569/#comment42373> Can we coord:nominalTime here and have the fixed value moved to one of the workflow test files. - Rohini Palaniswamy On May 14, 2013, 2:48 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10569/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 2:48 a.m.) > > > Review request for oozie. > > > Description > ------- > > 1. Revisiting the SLA handling in Oozie > 2. Addition of a calculator service to process sla events in a continuous > fashion > 3. Added new oozie-sla schema v0.2, concise and relevant > > > This addresses bug OOZIE-1244. > https://issues.apache.org/jira/browse/OOZIE-1244 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/AppType.java PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/JMSConnectionInfo.java > 1482171 > trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1482171 > trunk/client/src/main/java/org/apache/oozie/client/event/Event.java 1482171 > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java > 1482171 > trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java > 1482171 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > 1482171 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1482171 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > 1482171 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > 1482171 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > 1482171 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > 1482171 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1482171 > trunk/client/src/main/resources/oozie-coordinator-0.4.xsd 1482171 > trunk/client/src/main/resources/oozie-sla-0.2.xsd PRE-CREATION > trunk/client/src/main/resources/oozie-workflow-0.4.5.xsd 1482171 > trunk/client/src/main/resources/oozie-workflow-0.5.xsd PRE-CREATION > trunk/client/src/test/java/org/apache/oozie/client/rest/TestJsonToBean.java > 1482171 > trunk/core/pom.xml 1482171 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1482171 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1482171 > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonSLAEvent.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java 1482171 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java 1482171 > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventInsertJPAExecutor.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForSeqIdJPAExecutor.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetJPAExecutor.java > 1482171 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculatorGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/service/JMSTopicService.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1482171 > trunk/core/src/main/java/org/apache/oozie/service/SchedulerService.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/service/SchemaService.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1482171 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAJobEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/store/SLAStore.java 1482171 > trunk/core/src/main/java/org/apache/oozie/util/SLAOperations.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/util/XmlUtils.java 1482171 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1482171 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 1482171 > trunk/core/src/main/resources/META-INF/persistence.xml 1482171 > trunk/core/src/main/resources/oozie-default.xml 1482171 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java > 1482171 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1482171 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1482171 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java 1482171 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java > 1482171 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1482171 > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1482171 > trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > 1482171 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1482171 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1482171 > trunk/core/src/test/resources/coord-action-sla.xml PRE-CREATION > trunk/core/src/test/resources/wf-action-sla.xml PRE-CREATION > trunk/core/src/test/resources/wf-job-sla.xml PRE-CREATION > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1482171 > > Diff: https://reviews.apache.org/r/10569/diff/ > > > Testing > ------- > > ongoing > > > Thanks, > > Mona Chitnis > >
