----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11700/#review21607 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/11700/#comment44708> Can we keep updateRegistrationEvent as a separate method instead of adding a boolean rerun trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java <https://reviews.apache.org/r/11700/#comment44701> Can you check with Mona. She added this method for some reason. trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java <https://reviews.apache.org/r/11700/#comment44702> Need to get other fields like jobData, slaConfig.. which are not part of slasummary table trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java <https://reviews.apache.org/r/11700/#comment44703> Initialize to 0 trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java <https://reviews.apache.org/r/11700/#comment44704> Have two separate methods - addRegistration and updateRegistration trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11700/#comment44706> This is not required trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11700/#comment44705> This is not required trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/11700/#comment44707> not required trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java <https://reviews.apache.org/r/11700/#comment44709> Keep separate methods for add and update trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/11700/#comment44710> Add some info to description - Rohini Palaniswamy On June 9, 2013, 3:25 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11700/ > ----------------------------------------------------------- > > (Updated June 9, 2013, 3:25 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1339 > > The patch is built on top of OOZIE-1400, so some of its changes from > SLASummaryBean will be visible here. > > > This addresses bug OOZIE-1339. > https://issues.apache.org/jira/browse/OOZIE-1339 > > > Diffs > ----- > > > trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetRecordsOnRestartJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1490811 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > 1490811 > trunk/core/src/main/resources/oozie-default.xml 1490811 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1490811 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1490811 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1490811 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1490811 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1490811 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/11700/diff/ > > > Testing > ------- > > Unit test and end to end > > > Thanks, > > Virag Kothari > >
