> On June 9, 2013, 6:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java, line 40 > > <https://reviews.apache.org/r/11700/diff/2/?file=302158#file302158line40> > > > > Initialize to 0
byte would be set to 0 by default > On June 9, 2013, 6:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java, > > line 393 > > <https://reviews.apache.org/r/11700/diff/2/?file=302150#file302150line393> > > > > Can we keep updateRegistrationEvent as a separate method instead of > > adding a boolean rerun Changed SLACalcMemory and SLAService to have updateRegistrationEvent. Keeping the boolean rerun here as rerun for wf and coord are different. Rerun for wf recreates the reg bean while rerun for coord doesnt so coord rerun calls the SLAOperations.updateRegistartionEvent while wf Rerun calls SLAOperations.addRegistrationEvent > On June 9, 2013, 6:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, > > line 333 > > <https://reviews.apache.org/r/11700/diff/2/?file=302160#file302160line333> > > > > This is not required Required as there is no guarantee in ordering of events as multiple threads are accessing the queue For. e.g a fail event might generate a MISS and a start event coming later might overwrite this to IN_PROCESS - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11700/#review21607 ----------------------------------------------------------- On June 9, 2013, 3:25 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11700/ > ----------------------------------------------------------- > > (Updated June 9, 2013, 3:25 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1339 > > The patch is built on top of OOZIE-1400, so some of its changes from > SLASummaryBean will be visible here. > > > This addresses bug OOZIE-1339. > https://issues.apache.org/jira/browse/OOZIE-1339 > > > Diffs > ----- > > > trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > 1490811 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetRecordsOnRestartJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1490811 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > 1490811 > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > 1490811 > trunk/core/src/main/resources/oozie-default.xml 1490811 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1490811 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1490811 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1490811 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1490811 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1490811 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/11700/diff/ > > > Testing > ------- > > Unit test and end to end > > > Thanks, > > Virag Kothari > >
