> On June 10, 2013, 1:30 a.m., Rohini Palaniswamy wrote: > > SLARegistrationGetOnRestartJPAExecutor, > > SLASummaryGetRecordsOnRestartJPAExecutor, > > SLASummaryUpdateForSLAStatusJPAExecutor and > > SLASummaryUpdateForSLAStatusActualTimesJPAExecutor are missing in the patch
Also . -1 the patch contains 6 line(s) longer than 132 characters - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11700/#review21635 ----------------------------------------------------------- On June 9, 2013, 11:18 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11700/ > ----------------------------------------------------------- > > (Updated June 9, 2013, 11:18 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1339 > > The patch is built on top of OOZIE-1400, so some of its changes from > SLASummaryBean will be visible here. > > > This addresses bug OOZIE-1339. > https://issues.apache.org/jira/browse/OOZIE-1339 > > > Diffs > ----- > > > trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 1491310 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1491310 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1491310 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1491310 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1491310 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1491310 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 1491310 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1491310 > > trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > 1491310 > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > 1491310 > trunk/core/src/main/resources/oozie-default.xml 1491310 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 1491310 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1491310 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1491310 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 1491310 > > Diff: https://reviews.apache.org/r/11700/diff/ > > > Testing > ------- > > Unit test and end to end > > > Thanks, > > Virag Kothari > >
