----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review25903 -----------------------------------------------------------
Did you add any tests with DST? DST can get really tricky so its important that we test it. Also, OOZIE-1449 is, among other things, consolidating the JPA executor classes so we don't have so many of them; you should probably coordinate with Ryota to make sure your patches don't conflict with the JPA stuff. - Robert Kanter On Aug. 30, 2013, 10:54 p.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 10:54 p.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1518847 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1518847 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1518847 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1518847 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1518847 > /trunk/examples/src/main/apps/cron-schedule/coordinator.xml PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/job.properties PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/workflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
