----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review26557 -----------------------------------------------------------
Previously you had added CoordJobsGetRunningPastEndtimeJPAExecutor to handle cron frequencies which will still have more materializations to go even though it won't create any actions. Had asked to set done materialization to true if next materialization time is after coord job end time. CoordJobsGetRunningPastEndtimeJPAExecutor is removed, but setting done materialization is not in this patch. /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51794> Why is this required as it is already set to nextTime? /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51795> Please do not replace imports with * /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51797> Wasn't DST transition in 11 March 2012 2am ? Also on the boundary of transition, we expect it to be forward by one hour in Spring DST and backward by one hour in Winter DST. Refer to TestCoordELFunctions.testCurrent. /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51798> 4th November 2am was DST. - Rohini Palaniswamy On Sept. 25, 2013, 2:01 a.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 2:01 a.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1526083 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1526083 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1526083 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1526083 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1526083 > /trunk/examples/src/main/apps/cron-schedule/coordinator.xml PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/job.properties PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/workflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
