----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13961/#review26323 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java <https://reviews.apache.org/r/13961/#comment51419> the same comment for GET_COORD_JOB_STATUS, originally thought it's cleaner to add w.id in namedquery, but GET_BUNDLE_JOB_STATUS is used only here anyway, so it is fine. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/13961/#comment51418> originally thought it is cleaner to add w.id in namedQuery while removing coordJob.setId here, but this is only place to use GET_COORD_JOB_STATUS, so it is fine. trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java <https://reviews.apache.org/r/13961/#comment51417> isn't loadState the same with eagerloadState? can avoid repetition - Ryota Egashira On Sept. 20, 2013, 11:23 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13961/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2013, 11:23 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1503 > https://issues.apache.org/jira/browse/OOZIE-1503 > > > Repository: oozie > > > Description > ------- > > Patch to revisit eagerLoadState calls causing multiple DB calls, at times > redundant, and to load only select columns for eagerLoadState where applicable > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525149 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525149 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525149 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525149 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1525149 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java > 1525149 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1525149 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1525149 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1525149 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 1525149 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > 1525149 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java > 1525149 > > Diff: https://reviews.apache.org/r/13961/diff/ > > > Testing > ------- > > > Thanks, > > Mona Chitnis > >
