> On Sept. 25, 2013, 4:04 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java, > > line 60 > > <https://reviews.apache.org/r/13961/diff/4-5/?file=356571#file356571line60> > > > > Isn't status enough for eagerload?
GET_ATION_COMPLETED only gets minor fields - id, job-id, status, type and logtoken which will be < 10KB combined > On Sept. 25, 2013, 4:04 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java, > > line 147 > > <https://reviews.apache.org/r/13961/diff/4-5/?file=356574#file356574line147> > > > > jpa service not required jpaService object is being passed later to setPendingFalseForActions() and actions = jpaService.execute(new WorkflowActionRetryManualGetJPAExecutor(id)); So initialization will be required here. removing the null check - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13961/#review26376 ----------------------------------------------------------- On Sept. 25, 2013, 3:31 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13961/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 3:31 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1503 > https://issues.apache.org/jira/browse/OOZIE-1503 > > > Repository: oozie > > > Description > ------- > > Patch to revisit eagerLoadState calls causing multiple DB calls, at times > redundant, and to load only select columns for eagerLoadState where applicable > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java > 1526048 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1526048 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1526048 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 1526048 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > 1526048 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java > 1526048 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java > 1526048 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java > 1526048 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java > 1526048 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java > 1526048 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1526048 > > Diff: https://reviews.apache.org/r/13961/diff/ > > > Testing > ------- > > > Thanks, > > Mona Chitnis > >
