----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13961/#review26359 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java <https://reviews.apache.org/r/13961/#comment51467> Delete BundleActionsGetJPAExecutor trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java <https://reviews.apache.org/r/13961/#comment51446> Set it in the QueryExecutor itself instead of setting it here. trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java <https://reviews.apache.org/r/13961/#comment51447> Remove jpa service trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java <https://reviews.apache.org/r/13961/#comment51448> Remove jpa service trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java <https://reviews.apache.org/r/13961/#comment51453> We need these retries trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/13961/#comment51454> Remove this trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/13961/#comment51455> Do not change the signature of overriding method trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/13961/#comment51456> eagerVerifyPrecondition is removed. Should be there trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java <https://reviews.apache.org/r/13961/#comment51457> keep the retries trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java <https://reviews.apache.org/r/13961/#comment51458> keep the retry trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java <https://reviews.apache.org/r/13961/#comment51459> we should keep eagerLoad for this one. trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java <https://reviews.apache.org/r/13961/#comment51460> Remove this trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java <https://reviews.apache.org/r/13961/#comment51462> We should keep it trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java <https://reviews.apache.org/r/13961/#comment51463> We should keep it trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java <https://reviews.apache.org/r/13961/#comment51464> set the bundle id here trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java <https://reviews.apache.org/r/13961/#comment51465> set coord id here trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java <https://reviews.apache.org/r/13961/#comment51466> Why this change? - Rohini Palaniswamy On Sept. 24, 2013, 7:34 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13961/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2013, 7:34 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1503 > https://issues.apache.org/jira/browse/OOZIE-1503 > > > Repository: oozie > > > Description > ------- > > Patch to revisit eagerLoadState calls causing multiple DB calls, at times > redundant, and to load only select columns for eagerLoadState where applicable > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525636 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525636 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525636 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525636 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1525636 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java > 1525636 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1525636 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1525636 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1525636 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 1525636 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > 1525636 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1525636 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java > 1525636 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java > 1525636 > > Diff: https://reviews.apache.org/r/13961/diff/ > > > Testing > ------- > > > Thanks, > > Mona Chitnis > >
