----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review26620 -----------------------------------------------------------
/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51864> Why isn't 12:00 also materialized? /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51865> Why isn't 11:00 also materialized? /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment51861> Can we pass a higher limit (1000 or Integer.MAX_VALUE) here instead of number as it limits the result to number. If it materializes more actions than expected this test will never catch it. - Rohini Palaniswamy On Oct. 2, 2013, 12:38 a.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 12:38 a.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1528286 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1528286 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1528286 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1528286 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1528286 > /trunk/examples/src/main/apps/cron-schedule/coordinator.xml PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/job.properties PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/workflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
