> On Oct. 2, 2013, 7:23 p.m., Rohini Palaniswamy wrote: > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java, > > line 303 > > <https://reviews.apache.org/r/13362/diff/7/?file=360298#file360298line303> > > > > Why isn't 12:00 also materialized? > > Bowen Zhang wrote: > Because the job ends at that time. Similarly, if you have a job starts at > 10am and ends at 11am with frequency of ${coord:minutes(10)}, there will be > no materialization at 11:00am.
You are right. Initially thought it was inclusive of start and end. > On Oct. 2, 2013, 7:23 p.m., Rohini Palaniswamy wrote: > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java, > > line 593 > > <https://reviews.apache.org/r/13362/diff/7/?file=360298#file360298line593> > > > > Can we pass a higher limit (1000 or Integer.MAX_VALUE) here instead of > > number as it limits the result to number. If it materializes more actions > > than expected this test will never catch it. If you could just make this minor change I am good to go. You need not upload this change again in review board. Can directly upload in jira. Will +1 and commit. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review26620 ----------------------------------------------------------- On Oct. 2, 2013, 12:38 a.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 12:38 a.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1528286 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1528286 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1528286 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1528286 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1528286 > /trunk/examples/src/main/apps/cron-schedule/coordinator.xml PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/job.properties PRE-CREATION > /trunk/examples/src/main/apps/cron-schedule/workflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
