----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15225/#review29131 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/15225/#comment56258> Don't need eagerload and verify when executing synchronously trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/15225/#comment56259> 1) Throw an exception if the entitykey is different from the command you are executing. 2) Handle interrupts before execution trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java <https://reviews.apache.org/r/15225/#comment56277> Instead of passing isReady to updateCoordAction, can we move this out of finally and do the update in different places and do the queueing trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java <https://reviews.apache.org/r/15225/#comment56260> Shouldn't this be after event generation? trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java <https://reviews.apache.org/r/15225/#comment56278> Shouldn't this be after the event is generated? trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java <https://reviews.apache.org/r/15225/#comment56279> Shouldn't this be after generateEvent? trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java <https://reviews.apache.org/r/15225/#comment56280> Shouldn't this be after event generation? trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java <https://reviews.apache.org/r/15225/#comment56281> Shouldn't this be after generate event? trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java <https://reviews.apache.org/r/15225/#comment56282> This should also be before the synchronous execution - Rohini Palaniswamy On Nov. 19, 2013, 4:01 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15225/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2013, 4:01 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1581 > https://issues.apache.org/jira/browse/OOZIE-1581 > > > Repository: oozie > > > Description > ------- > > Patch for review updated from the attachments on JIRA. > 1. Included change to call coordinator action Start synchronously from Ready > command. > 2. Made Decision Action Executor extend from Control Action Executor. That > way the synchronous commands can be executed for all such 'connector' actions. > 3. Fixed failing unit tests. > 4. TestSLAEventGeneration unit test is failing - WIP. > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1543124 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1543124 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1543124 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1543124 > trunk/core/src/test/resources/wf-fork.xml 1543124 > > Diff: https://reviews.apache.org/r/15225/diff/ > > > Testing > ------- > > unit tests fixed. stress testing performed to validate the fast start case. > > > Thanks, > > Mona Chitnis > >
