----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15225/#review29170 -----------------------------------------------------------
comments discussed offline trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/15225/#comment56310> if you think most of the code is duplicated, then better to create a method which can be shared by call() trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/15225/#comment56311> can we have a trace log saying command is executed synchronously. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java <https://reviews.apache.org/r/15225/#comment56309> we need to have it same as before, so that coordinator is not updated before wf job finishes submission. trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java <https://reviews.apache.org/r/15225/#comment56308> if this is part of exception, then its not a control node. Need to queue and set execSycnhronous to false. trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java <https://reviews.apache.org/r/15225/#comment56306> check for ControlNodeActionExecutor? trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java <https://reviews.apache.org/r/15225/#comment56305> Move the code back to where it was before, otherwise the coordactionupdate will happen before the wf job updates are persisted - Virag Kothari On Nov. 20, 2013, 2:31 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15225/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 2:31 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1581 > https://issues.apache.org/jira/browse/OOZIE-1581 > > > Repository: oozie > > > Description > ------- > > Patch for review updated from the attachments on JIRA. > 1. Included change to call coordinator action Start synchronously from Ready > command. > 2. Made Decision Action Executor extend from Control Action Executor. That > way the synchronous commands can be executed for all such 'connector' actions. > 3. Fixed failing unit tests. > 4. TestSLAEventGeneration unit test is failing - WIP. > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1543124 > trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1543124 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1543124 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1543124 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1543124 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java > 1543124 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1543124 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1543124 > trunk/core/src/test/resources/wf-fork.xml 1543124 > > Diff: https://reviews.apache.org/r/15225/diff/ > > > Testing > ------- > > unit tests fixed. stress testing performed to validate the fast start case. > > > Thanks, > > Mona Chitnis > >
