-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15225/
-----------------------------------------------------------
(Updated Nov. 23, 2013, 2:36 a.m.)
Review request for oozie.
Changes
-------
Addressed review comments. Note - synchronous calling will cause NPE in
CoordActionUpdate command, if the workflow is a no-op wf. no-op workflows are
not real use-case anyway, so the examples which had no-op wf have also been
updated to have an empty single action (almost no-op). The patch also renames
the dir 'examples/src/main/apps/no-op' to 'examples/src/main/apps/one-op', but
svn is giving some pain to include a rename in the patch. Will remove and add
dir while committing.
Bugs: OOZIE-1581
https://issues.apache.org/jira/browse/OOZIE-1581
Repository: oozie
Description
-------
Patch for review updated from the attachments on JIRA.
1. Included change to call coordinator action Start synchronously from Ready
command.
2. Made Decision Action Executor extend from Control Action Executor. That way
the synchronous commands can be executed for all such 'connector' actions.
3. Fixed failing unit tests.
4. TestSLAEventGeneration unit test is failing - WIP.
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1544635
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
1544635
trunk/core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java
1544635
trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java
1544635
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1544635
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java
1544635
trunk/core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java
1544635
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java
1544635
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
1544635
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java
1544635
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java
1544635
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1544635
trunk/core/src/test/resources/wf-fork.xml 1544635
trunk/core/src/test/resources/wf-no-op.xml 1544635
trunk/examples/src/main/apps/cron-schedule/workflow.xml 1544635
trunk/examples/src/main/apps/cron/workflow.xml 1544635
trunk/examples/src/main/apps/sla/workflow.xml 1544635
Diff: https://reviews.apache.org/r/15225/diff/
Testing
-------
unit tests fixed. stress testing performed to validate the fast start case.
Thanks,
Mona Chitnis
