> On March 25, 2014, 11:10 p.m., Rohini Palaniswamy wrote: > > Weren't we also planning to add a --non-succeeded option (or some other > > nice name which is also easy to type) to filter out SUCCEEDED actions and > > show everything else which is what the users mainly wanted? Is that part of > > a separate jira? Doing > > --filter=status=RUNNING\;status=WAITING\;status=PREP\;STATUS=FAILED\;STATUS=KILLED\;STATUS=SUSPENDED > > is really not appealing.
original ask from customers was to sort result by status, and they want to see TIMEDOUT/FAILED/KILLED on top. I felt reluctant to add very specific option for filter like --non-succeeded, since some like to see FAILED/KILLED only, others like FAILED/KILED/TIMEOUT, or FAILED/KILLED/TIEEOUT/SUSPENDED, and we should not add new option for each combination, hence kept this patch minimum. but totally agree with that it's cumbersome for customers to add multiple status in filter. for the same reason, exclude filter also might not so appealing, since we still need to append multiple status similarly.. i'm inclined to add -groupby/-sortby option (e.g,. -groupby status) which used for better format on CLI (no change on API/backend side), also sounds standard option. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19619/#review38551 ----------------------------------------------------------- On March 25, 2014, 10:43 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19619/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 10:43 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1754 > https://issues.apache.org/jira/browse/OOZIE-1754 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1754 > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java a6203c6 > client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > f174b06 > docs/src/site/twiki/DG_CommandLineTool.twiki c13b78a > docs/src/site/twiki/WebServicesAPI.twiki 4b20075 > > Diff: https://reviews.apache.org/r/19619/diff/ > > > Testing > ------- > > did local test > > > Thanks, > > Ryota Egashira > >
