----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19619/#review38849 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/19619/#comment71171> Can we just pass null instead of instantiating a empty arraylist and handle null in CoordJobGetActionsSubsetJPAExecutor. Can be done for filterList as well? - Rohini Palaniswamy On March 27, 2014, 10:35 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19619/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 10:35 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1754 > https://issues.apache.org/jira/browse/OOZIE-1754 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1754 > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b > client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > a7fe06e > core/src/main/java/org/apache/oozie/BaseEngine.java 135a0a3 > core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024 > core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 0a030af > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > 21506ab > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9 > core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java bb69d7f > core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > db591e2 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > da7d16c > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > f174b06 > docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9 > docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0 > > Diff: https://reviews.apache.org/r/19619/diff/ > > > Testing > ------- > > did local test > > > Thanks, > > Ryota Egashira > >
