----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19619/#review39705 -----------------------------------------------------------
Ship it! core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/19619/#comment72310> Why is this check there? You can only have positive only or negative only filters right? Can you remove this in the final patch before check in? - Rohini Palaniswamy On April 3, 2014, 9:24 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19619/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 9:24 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1754 > https://issues.apache.org/jira/browse/OOZIE-1754 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1754 > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java e1f551d > client/src/main/java/org/apache/oozie/client/OozieClient.java 46c4288 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024 > core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 0a030af > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > 21506ab > core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > db591e2 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > da7d16c > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > f174b06 > docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 > docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0 > > Diff: https://reviews.apache.org/r/19619/diff/ > > > Testing > ------- > > did local test > > > Thanks, > > Ryota Egashira > >
