> On May 13, 2014, 9:55 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/service/ZKUUIDService.java, line 55 > > <https://reviews.apache.org/r/21046/diff/3/?file=580589#file580589line55> > > > > I'm not sure we should make the path configurable; I'm concerned that > > will just lead to a user accidentally setting them different in different > > servers and then running into problems because Oozie servers are using > > different paths. Or what happens if they try to use a patch Oozie is > > already using for something else? > > > > Also, please verify that when you run Oozie with ZKUUIDService, the > > path gets created under the namespace set for the server (default "oozie") > > and not simply at the root. e.g. /oozie/job_id_sequence > > > > Also, can you add a class javadoc comment to ZKUUIDService mentioning > > the path it's using (see ZKUtils and ZKLocksService for an example of what > > I mean) > > Purshotam Shah wrote: > >I'm not sure we should make the path configurable; I'm concerned that > will just lead to a user accidentally setting them different in different > servers and then >running into problems because Oozie servers are using > different paths. Or what happens if they try to use a patch Oozie is already > using for something else? > > Even Namespace is configurable, it should be ok. Most of the people will > verify their setting before moving to production. > > > I have verified and our QE will also verify that. Path are created under > namespace. > > >
Thanks for verifying it's under the namespace. I'm still not sure it's a good idea to make this path configurable; it's just another thing that the user can mix up between Oozie servers and run into problems. None of the other things are configurable (e.g. ZK Locks go under /locks, service discovery is under /services/servers, etc). Why do you want this to be configurable? - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21046/#review42891 ----------------------------------------------------------- On May 15, 2014, 6:43 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21046/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 6:43 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1715 > https://issues.apache.org/jira/browse/OOZIE-1715 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1715 Distributed ID sequence for HA > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/DistributedUUIDService.java > e69de29 > core/src/main/java/org/apache/oozie/service/UUIDService.java 836815d > core/src/main/java/org/apache/oozie/service/ZKUUIDService.java e69de29 > core/src/main/java/org/apache/oozie/util/ZKUtils.java 56055b8 > core/src/test/java/org/apache/oozie/service/TestDistributedUUIDService.java > e69de29 > core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java e69de29 > > Diff: https://reviews.apache.org/r/21046/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
