----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21046/#review43396 -----------------------------------------------------------
Can you add the new config properties to oozie-default and/or oozie-site? Can you also update the HA install documentation? core/src/main/java/org/apache/oozie/service/ZKUUIDService.java <https://reviews.apache.org/r/21046/#comment77487> What happens if the user sets this too high (i.e. more than the number of digits we use for the sequence part of the ID)? What happens if the user sets this too low (i.e. a negative number, or say, 5)? Perhaps we should have some hardcoded limits on the range of this? core/src/main/java/org/apache/oozie/service/ZKUUIDService.java <https://reviews.apache.org/r/21046/#comment77486> alread(y) what? - Robert Kanter On May 15, 2014, 6:43 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21046/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 6:43 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1715 > https://issues.apache.org/jira/browse/OOZIE-1715 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1715 Distributed ID sequence for HA > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/DistributedUUIDService.java > e69de29 > core/src/main/java/org/apache/oozie/service/UUIDService.java 836815d > core/src/main/java/org/apache/oozie/service/ZKUUIDService.java e69de29 > core/src/main/java/org/apache/oozie/util/ZKUtils.java 56055b8 > core/src/test/java/org/apache/oozie/service/TestDistributedUUIDService.java > e69de29 > core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java e69de29 > > Diff: https://reviews.apache.org/r/21046/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
