> On May 19, 2014, 6:57 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/service/ZKUUIDService.java, line 60
> > <https://reviews.apache.org/r/21046/diff/4/?file=582685#file582685line60>
> >
> > What happens if the user sets this too high (i.e. more than the number
> > of digits we use for the sequence part of the ID)?
> >
> > What happens if the user sets this too low (i.e. a negative number, or
> > say, 5)?
> >
> > Perhaps we should have some hardcoded limits on the range of this?
>What happens if the user sets this too low (i.e. a negative number, or say,
>5)?
I don't think any body will set -ve value for sequence, if we go that way there
will be so many scenario to consider.
This is how ID looks like.
Id sequence
-
yyMMddHHmmssSSS - server start time.
-
system id - systemId = conf.get(CONF_SYSTEM_ID, ("oozie-" +
System.getProperty("user.name")));
-
w/c/b.
total should not exceed 40 char.
So there may not be hard limit, if user configure systemID with less char then
he can have higher sequence.
Its more for a user to calculate.
For HA, i will take out "SSS" from start time, so that we can higher sequence.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21046/#review43396
-----------------------------------------------------------
On May 15, 2014, 6:43 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21046/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 6:43 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1715
> https://issues.apache.org/jira/browse/OOZIE-1715
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-1715 Distributed ID sequence for HA
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/DistributedUUIDService.java
> e69de29
> core/src/main/java/org/apache/oozie/service/UUIDService.java 836815d
> core/src/main/java/org/apache/oozie/service/ZKUUIDService.java e69de29
> core/src/main/java/org/apache/oozie/util/ZKUtils.java 56055b8
> core/src/test/java/org/apache/oozie/service/TestDistributedUUIDService.java
> e69de29
> core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java e69de29
>
> Diff: https://reviews.apache.org/r/21046/diff/
>
>
> Testing
> -------
>
> UTC
>
>
> Thanks,
>
> Purshotam Shah
>
>
