----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review45914 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/19449/#comment81040> Can you specify dataInName in the exceptions. When there are multiple data ins for a coord, its difficult to figure out for which data in the error is for core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/19449/#comment81039> There should be validation on type in the beginning of the function core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java <https://reviews.apache.org/r/19449/#comment81041> why do you need assertEquals here? core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java <https://reviews.apache.org/r/19449/#comment81042> why do you need assertEquals here? core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java <https://reviews.apache.org/r/19449/#comment81043> Can you add another test with different type (not hive-export) docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/19449/#comment81044> Uses dataInPartitions for output docs/src/site/twiki/CoordinatorFunctionalSpec.twiki <https://reviews.apache.org/r/19449/#comment81046> extra) sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/19449/#comment81045> throw unhandled type - shwethags On June 16, 2014, 1:09 p.m., Satish Mittal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19449/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 1:09 p.m.) > > > Review request for oozie, Ryota Egashira and Rohini Palaniswamy. > > > Repository: oozie-git > > > Description > ------- > > Currently oozie provides coord EL functions to get partition filter string > (where key-values are separated by AND) for various action types - > java/pig/hive. However this doesn't work in other cases, e.g. hive action > that performs export/import of hive partition. In that case, the partition > value is expected to be in a different format: > (col1="value1",col2="value2"...). > > If we use any existing EL function like coord:dataInPartitionFilter, the > value of partition looks like: > (minute='00' AND month='03' AND year='2014' AND hour='09' AND day='11') > In this case, Hive export fails with error: > FAILED: ParseException line 1:51 mismatched input 'AND' expecting ) near > ''00'' in export statement > > We need to add a new EL function that returns partition value in the above > format. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java e5f0146 > core/src/main/resources/oozie-default.xml c9d9591 > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f63b682 > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 11018b0 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java d797f9b > > Diff: https://reviews.apache.org/r/19449/diff/ > > > Testing > ------- > > - Manually verified the new EL function on my local setup. > - Added new test cases for the same. > > > Thanks, > > Satish Mittal > >
