> On June 17, 2014, 6:37 a.m., shwethags wrote: > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, line 303 > > <https://reviews.apache.org/r/19449/diff/5/?file=610674#file610674line303> > > > > There should be validation on type in the beginning of the function
Added validation for any other type than hive-export. > On June 17, 2014, 6:37 a.m., shwethags wrote: > > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java, line 292 > > <https://reviews.apache.org/r/19449/diff/5/?file=610676#file610676line292> > > > > why do you need assertEquals here? -ve test case; was written similar to other tests in this class. Have removed assertEquals now. > On June 17, 2014, 6:37 a.m., shwethags wrote: > > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java, line 301 > > <https://reviews.apache.org/r/19449/diff/5/?file=610676#file610676line301> > > > > why do you need assertEquals here? -ve test case; was written similar to other tests in this class. Have removed assertEquals now. > On June 17, 2014, 6:37 a.m., shwethags wrote: > > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java, line 305 > > <https://reviews.apache.org/r/19449/diff/5/?file=610676#file610676line305> > > > > Can you add another test with different type (not hive-export) Added a -ve test scenario in testDataInPartitions() to execute EL with a different type than hive-export. > On June 17, 2014, 6:37 a.m., shwethags wrote: > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 2918 > > <https://reviews.apache.org/r/19449/diff/5/?file=610677#file610677line2918> > > > > Uses dataInPartitions for output Have renamed various property names in example from IN/OUT prefixes to EXPORT/IMPORT prefixes for better clarity. - Satish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review45914 ----------------------------------------------------------- On June 17, 2014, 11:01 a.m., Satish Mittal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19449/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 11:01 a.m.) > > > Review request for oozie, Ryota Egashira and Rohini Palaniswamy. > > > Repository: oozie-git > > > Description > ------- > > Currently oozie provides coord EL functions to get partition filter string > (where key-values are separated by AND) for various action types - > java/pig/hive. However this doesn't work in other cases, e.g. hive action > that performs export/import of hive partition. In that case, the partition > value is expected to be in a different format: > (col1="value1",col2="value2"...). > > If we use any existing EL function like coord:dataInPartitionFilter, the > value of partition looks like: > (minute='00' AND month='03' AND year='2014' AND hour='09' AND day='11') > In this case, Hive export fails with error: > FAILED: ParseException line 1:51 mismatched input 'AND' expecting ) near > ''00'' in export statement > > We need to add a new EL function that returns partition value in the above > format. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java e5f0146 > core/src/main/resources/oozie-default.xml b944d3d > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f63b682 > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 961377e > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java d797f9b > > Diff: https://reviews.apache.org/r/19449/diff/ > > > Testing > ------- > > - Manually verified the new EL function on my local setup. > - Added new test cases for the same. > > > Thanks, > > Satish Mittal > >
