----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25269/#review54546 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java <https://reviews.apache.org/r/25269/#comment94712> No code in Oozie should check for if(scheme.equals(...)). Please use the URIHandlerFactory to determine the URIHandler for a specific URI scheme. core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java <https://reviews.apache.org/r/25269/#comment94713> This should be implemented and used by cleanupOutputEvents core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/25269/#comment94715> Don't think this code will work. You need to get delegation token as oozie for that user and create a new client with that delegation token and call drop partitions on that client. The doAs block does not sound right and so does using hive-site.xml. You are breaking the whole support for multiple hcat servers and configurations (HCatAccessorService) with that. - Rohini Palaniswamy On Sept. 17, 2014, 3:48 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25269/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 3:48 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1985 > https://issues.apache.org/jira/browse/OOZIE-1985 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1985 > > > Diffs > ----- > > client/.gitignore PRE-CREATION > core/src/main/java/org/apache/oozie/ErrorCode.java 88a2c67 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java > 0f0ac20 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java > 15bd2bf > core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > f75be07 > core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java f6955ac > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java da78105 > core/src/main/java/org/apache/oozie/dependency/URIHandler.java eaf1fd2 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 92b2190 > core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java > a2383c6 > > Diff: https://reviews.apache.org/r/25269/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
