----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25269/#review59601 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/ErrorCode.java <https://reviews.apache.org/r/25269/#comment100895> One code for "Failed to delete uri : {0}" should be good enough. User can make out hdfs or hcat from the uri. core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java <https://reviews.apache.org/r/25269/#comment100898> FileSystem fs = getFileSystem(uri, conf, user); core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/25269/#comment100903> HCatClient client = getHCatClient(uri, conf, user); client.dropPartitions(hcatUri.getDb(), hcatUri.getTable(), hcatUri.getPartitionMap(), true); core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/25269/#comment100904> Please change this method to getHCatClient(uri, conf, user) which only returns HCatClient; core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/25269/#comment100905> Inline this method into getHCatClient() core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/25269/#comment100902> Make this method as getHCatClient(URI uri, Configuration conf) which retuns HCatClient for Oozie server and add new code in getHCatClient(URI uri, Configuration conf, String user) core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java <https://reviews.apache.org/r/25269/#comment100901> Need to these changes. XLog.getLog(HCatURIHandler.class) is required to get the latest log prefix information. core/src/main/java/org/apache/oozie/dependency/URIHandler.java <https://reviews.apache.org/r/25269/#comment100900> * Delete a URI * @param uri URI - Rohini Palaniswamy On Oct. 31, 2014, 5:43 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25269/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 5:43 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1985 > https://issues.apache.org/jira/browse/OOZIE-1985 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1985 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/ErrorCode.java 4afeb6c > core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 098eb4b > core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java a8f548a > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 629033b > core/src/main/java/org/apache/oozie/dependency/URIHandler.java 7280902 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 65338a3 > core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java > 31a68bf > > Diff: https://reviews.apache.org/r/25269/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
