> On Sept. 25, 2014, 4:15 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java, line 220
> > <https://reviews.apache.org/r/25269/diff/2/?file=692566#file692566line220>
> >
> >     Don't think this code will work.
> >     
> >     You need to get delegation token as oozie for that user and create a 
> > new client with that delegation token and call drop partitions on that 
> > client. The doAs block does not sound right and so does using 
> > hive-site.xml. You are breaking the whole support for multiple hcat servers 
> > and configurations (HCatAccessorService) with that.

thanks,  yes, this didn't work in my test environment, and was wondeirng how to 
fix.

>so does using hive-site.xml. You are breaking the whole support for multiple 
>hcat servers 

to get metastore uri and principal info,  I thought of three possible 
approaches.
1) get <credentail> information from workflow.xml
2) add <credentials> in coordinator.xml
3) use hive-site.xml on server

I didin't like 1) since coordiantor.xml procsssing should not depend on 
workflow.xml. 
2) option, just thought too much for users since this is only used when rerun 
with cleanup option. (and user end up specifying <credentials> both in 
coordiantor and workflow)
so went with 3), thinkning of supporting majority of use case accessing default 
hcat server.  but definitely supporting multiple hcat servers is issue.


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25269/#review54546
-----------------------------------------------------------


On Sept. 17, 2014, 3:48 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25269/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 3:48 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1985
>     https://issues.apache.org/jira/browse/OOZIE-1985
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1985
> 
> 
> Diffs
> -----
> 
>   client/.gitignore PRE-CREATION 
>   core/src/main/java/org/apache/oozie/ErrorCode.java 88a2c67 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java 
> 0f0ac20 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 
> 15bd2bf 
>   core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 
> f75be07 
>   core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java f6955ac 
>   core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java da78105 
>   core/src/main/java/org/apache/oozie/dependency/URIHandler.java eaf1fd2 
>   
> core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 
> 92b2190 
>   core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java 
> a2383c6 
> 
> Diff: https://reviews.apache.org/r/25269/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Reply via email to