----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28136/#review66957 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/28136/#comment110710> String fragmentName = new URI(actionLibPath.toString()).getFragment(); String fileName = fragmentName == null ? path.getName() : fragmentName; core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/28136/#comment110695> Check filename only if fragment name is null core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/28136/#comment110697> action conf core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/28136/#comment110712> Add comment // Filtering out duplicate jars or files core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment110705> Not used core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment110699> LAUNCHER_LIB_PREFIX core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment111476> Need not pass Set<String> keyConfList and Map<String, Map<Path, Configuration>> shareLibConfigMap core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment111475> fragment? core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment111477> These can be done inside the getPathRecursively method and need not be passed as args core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment111479> property.file -> config.file Also this code should be in the instrument method core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment111480> Need to add the full paths core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment110708> Why is this required? core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/28136/#comment111482> Do this in initialize once and cache it as this would not change. core/src/test/java/org/apache/oozie/service/TestShareLibService.java <https://reviews.apache.org/r/28136/#comment111489> We should make the last one take precedence core/src/test/java/org/apache/oozie/service/TestShareLibService.java <https://reviews.apache.org/r/28136/#comment111488> third assert? hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java <https://reviews.apache.org/r/28136/#comment110703> hasYARN() hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java <https://reviews.apache.org/r/28136/#comment111485> why is this required? Add a comment to the code explaining why this is needed. - Rohini Palaniswamy On Jan. 5, 2015, 11:31 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28136/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 11:31 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2068 > https://issues.apache.org/jira/browse/OOZIE-2068 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2068 - sharelib support for conf > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > d70c3e1 > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 832bbe6 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > f207d74 > core/src/main/java/org/apache/oozie/service/ShareLibService.java bb0c7ed > core/src/main/resources/oozie-default.xml 3d07c6f > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 48166a5 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > d2ad881 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > f261448 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki 21199e8 > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > 9a19770 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > bea4781 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > acebd60 > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > acebd60 > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > a76014c > > Diff: https://reviews.apache.org/r/28136/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
