> On Jan. 9, 2015, 7:08 p.m., Rohini Palaniswamy wrote: > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java, > > line 47 > > <https://reviews.apache.org/r/28136/diff/3/?file=807205#file807205line47> > > > > hasYARN()
isYARN > On Jan. 9, 2015, 7:08 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/service/TestShareLibService.java, line > > 752 > > <https://reviews.apache.org/r/28136/diff/3/?file=807203#file807203line752> > > > > third assert? third assert is pig.jar, which will match assertTrue(shareLib.toString().contains("pig.jar#pig.jar")); > On Jan. 9, 2015, 7:08 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/service/TestShareLibService.java, line > > 747 > > <https://reviews.apache.org/r/28136/diff/3/?file=807203#file807203line747> > > > > We should make the last one take precedence First one should take precedence . When we set classpath we expect that first jar should take precedence, same should be applicable here. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28136/#review66957 ----------------------------------------------------------- On Jan. 5, 2015, 11:31 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28136/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 11:31 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2068 > https://issues.apache.org/jira/browse/OOZIE-2068 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2068 - sharelib support for conf > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > d70c3e1 > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 832bbe6 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > f207d74 > core/src/main/java/org/apache/oozie/service/ShareLibService.java bb0c7ed > core/src/main/resources/oozie-default.xml 3d07c6f > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 48166a5 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > d2ad881 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > f261448 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki 21199e8 > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > 9a19770 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > bea4781 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > acebd60 > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > acebd60 > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > a76014c > > Diff: https://reviews.apache.org/r/28136/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
