> On Jan. 16, 2015, 7:36 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 595 > > <https://reviews.apache.org/r/28136/diff/3-4/?file=807198#file807198line595> > > > > path.toUri()
path.toUri() doesn't work. > On Jan. 16, 2015, 7:36 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/service/ShareLibService.java, line 902 > > <https://reviews.apache.org/r/28136/diff/3-4/?file=807199#file807199line902> > > > > path.toUri() path.toUri() doesn't work. > On Jan. 16, 2015, 7:36 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 597 > > <https://reviews.apache.org/r/28136/diff/3-4/?file=807198#file807198line597> > > > > actionLibPath.toUri() path.toUri() doesn't work. > On Jan. 16, 2015, 7:36 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/service/ShareLibService.java, lines > > 904-909 > > <https://reviews.apache.org/r/28136/diff/3-4/?file=807199#file807199line904> > > > > Code should not depend on naming convention. Check against shareLibKey > > is redundant This is to protect extra caching of config file. Since we are loading the conf file in memory, it's good if we can avoid caching of unnecessary files. We don't need to cache config files, if pig/hact has hive-site.xml. I will change startwith logic with contains. > On Jan. 16, 2015, 7:36 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 596 > > <https://reviews.apache.org/r/28136/diff/3-4/?file=807198#file807198line596> > > > > pathWithoutFragment > > > > path.toUri() It is pathWithFragment. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28136/#review68455 ----------------------------------------------------------- On Jan. 15, 2015, 10:48 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28136/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 10:48 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2068 > https://issues.apache.org/jira/browse/OOZIE-2068 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2068 - sharelib support for conf > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > d70c3e1 > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 832bbe6 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > f207d74 > core/src/main/java/org/apache/oozie/service/ShareLibService.java bb0c7ed > core/src/main/resources/oozie-default.xml 3d07c6f > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 48166a5 > core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java > d2ad881 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > f261448 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki 21199e8 > > hadooplibs/hadoop-utils-0.23/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > 9a19770 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > bea4781 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > acebd60 > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > acebd60 > tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java > a76014c > > Diff: https://reviews.apache.org/r/28136/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
