[
https://issues.apache.org/jira/browse/OOZIE-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501040#comment-15501040
]
Hadoop QA commented on OOZIE-2657:
----------------------------------
Testing JIRA OOZIE-2657
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1804
. Tests failed: 1
. Tests errors: 0
. The patch failed the following testcases:
.
testCoordActionInputCheckXCommandUniqueness(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3292/
> Clean up redundant access modifiers from oozie interfaces
> ---------------------------------------------------------
>
> Key: OOZIE-2657
> URL: https://issues.apache.org/jira/browse/OOZIE-2657
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Abhishek Bafna
> Assignee: Abhishek Bafna
> Priority: Minor
> Labels: code-cleanup
> Fix For: 4.3.0
>
> Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
>
>
> By default java {{interface}} fields are {{public static final}}. Some of the
> Oozie interface still explicitly declare these redundant access modifier. I
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
> public static final String VERSIONS = "versions";
> public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
> public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for
> V0 only
> public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
